review: fix: Correctly adapt type parameters inherited from enclosing classes #5228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
I-Al-Istannen
force-pushed
the
fix/issue-5226
branch
from
014bac8 to
53c3eb7
Compare
I-Al-Istannen
changed the title
I-Al-Istannen
changed the title
SirYwell
requested changes
May 24, 2023
SirYwell
approved these changes
May 24, 2023
|
thanks @I-Al-Istannen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
Type adaption did not handle using generics inherited from enclosing classes. In these cases, a type hierarchy from the innermost class to its parent class was built, causing the generic resolution to fail.
This PR fixes this by adjusting building a hierarchy between the declaring types instead.
todo
docs/type_adaption.mdcloses
This closes #5226.